[PATCH] D25747: [clang-tidy] Fix an assertion failure in cppcoreguidelines-pro-type-member-init.

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 20 06:22:29 PDT 2016


hokein added inline comments.


================
Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:30
 
+AST_MATCHER(CXXRecordDecl, hasDefaultConstructor) {
+  return Node.hasDefaultConstructor();
----------------
aaron.ballman wrote:
> I think this should be a public AST matcher rather than a private one; it seems like it would be generally useful (along with some of the other similar has* functions). However, I think it's fine for this patch.
+1, will do it in a follow-up.


https://reviews.llvm.org/D25747





More information about the cfe-commits mailing list