[PATCH] D25450: [clang-tidy] Fix identifier naming in macro args.

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 20 06:13:34 PDT 2016


aaron.ballman added inline comments.


================
Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:654
+      RangeIsEntirelyWithinMacroArgument || !RangeContainsMacroExpansion;
+  Failure.ShouldFix = Failure.ShouldFix && RangeCanBeFixed;
 }
----------------
We could do an early return if `ShouldFix` is already false and simplify this expression with `ShouldFix = RangeCanBeFixed;`, can't we?


https://reviews.llvm.org/D25450





More information about the cfe-commits mailing list