[PATCH] D25777: [Sema][TreeTransform] Re-create DesignatedInitExpr when it has a field designator with a valid FieldDecl

Manman Ren via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 19 14:52:54 PDT 2016


manmanren added a comment.

It makes sense to rebuild the expression when a field designator stores a FieldDecl.

Thanks for working on this!
Manman



================
Comment at: lib/Sema/TreeTransform.h:8926
                                                D.getFieldLoc()));
+      if (D.getField())
+        ExprChanged = true;
----------------
Please add comment here on why we need to set ExprChanged to true.


Repository:
  rL LLVM

https://reviews.llvm.org/D25777





More information about the cfe-commits mailing list