[PATCH] D25621: DebugInfo: use uin32_t for alignment

Victor Leschuk via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 19 06:56:07 PDT 2016


vleschuk added a comment.

In https://reviews.llvm.org/D25621#573671, @aprantl wrote:

> This patch is conflating two set of changes:
>  (1) NFC: rename all occurrences of unsigned for alignment purposes in the frontend with uint32_t
>  (2) shrink all debug-info-related alignment variables from uint64_t -> unint32_t.
>
> I think this patch should only be doing the changes in (2).


Agreed. Update this one. The (1) will come as separate NFC review along with corresponding LLVM patch.


https://reviews.llvm.org/D25621





More information about the cfe-commits mailing list