[PATCH] D25621: DebugInfo: use DIAlignment type.

Victor Leschuk via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 17 04:36:59 PDT 2016


vleschuk marked an inline comment as done.
vleschuk added inline comments.


================
Comment at: include/clang/AST/ASTContext.h:83
     uint64_t Width;
-    unsigned Align;
+    llvm::DIAlignment Align;
     bool AlignIsRequired : 1;
----------------
aprantl wrote:
> I'm not sure we want to use a debug info type inside the AST. I think we only want to use them in CGDebugInfo.cpp.
We use TypeInfo and related functions heavily in CGDebugInfo.cpp, leaving this field as "unsigned" will make us to perform conversions from "unsigned" to llvm::DIAlignment, I think having this changed will result in simpler code.


https://reviews.llvm.org/D25621





More information about the cfe-commits mailing list