r284335 - [analyzer] Make MallocChecker more robust against custom redeclarations

[Devin Coughlin via cfe-commits]

> On Oct 16, 2016, at 12:04 PM, Renato Golin <renato.golin at linaro.org> wrote:
> 
> On 16 October 2016 at 18:26, Devin Coughlin via cfe-commits
> <cfe-commits at lists.llvm.org> wrote:
>> Author: dcoughlin
>> Date: Sun Oct 16 12:26:06 2016
>> New Revision: 284335
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=284335&view=rev
>> Log:
>> [analyzer] Make MallocChecker more robust against custom redeclarations
>> 
>> Add additional checking to MallocChecker to avoid crashing when memory
>> routines have unexpected numbers of arguments. You wouldn't expect to see much
>> of this in normal code (-Wincompatible-library-redeclaration warns on this),
>> but, for example, CMake tests can generate these.
> 
> Hi Devin,
> 
> Sounds like yours:
> 
> http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/11121

I’ll speculatively revert. But I don’t understand how a static analyzer-only change could affect either the execution time or the compile time of a test-suite benchmark. There’s something very funny here.

Devin