[PATCH] D25624: Added 'inline' attribute to basic_string's destructor

Aditya Kumar via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 14 09:11:56 PDT 2016


hiraditya created this revision.
hiraditya added reviewers: mclow.lists, EricWF.
hiraditya added subscribers: laxmansole, sebpop, cfe-commits.

Author: laxmansole

      

Original Differential Revision: https://reviews.llvm.org/D22834

      

Posting the patch again as the bug https://llvm.org/bugs/show_bug.cgi?id=30341 is fixed.

      

Currently basic_string's destructor is not getting inlined. So adding 'inline' attribute to ~basic_string().
Worked in collaboration with Aditya Kumar.

      

git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@280944 91177308-0d34-0410-b5e6-96231b3b80d8


https://reviews.llvm.org/D25624

Files:
  include/string


Index: include/string
===================================================================
--- include/string
+++ include/string
@@ -1834,6 +1834,7 @@
 #endif  // _LIBCPP_HAS_NO_GENERALIZED_INITIALIZERS
 
 template <class _CharT, class _Traits, class _Allocator>
+inline _LIBCPP_INLINE_VISIBILITY
 basic_string<_CharT, _Traits, _Allocator>::~basic_string()
 {
 #if _LIBCPP_DEBUG_LEVEL >= 2


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25624.74699.patch
Type: text/x-patch
Size: 389 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161014/a0c9880c/attachment.bin>


More information about the cfe-commits mailing list