[PATCH] D25343: [OpenCL] Mark group functions as convergent in opencl-c.h

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 13 09:59:21 PDT 2016


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

Aside from some minor nits, the attribute functionality looks fine to me. As to whether we think this is a worthy attribute to add or not, I leave that to people who know CUDA and OpenCL better than I do, so please wait for @tstellarAMD or @Anastasia to sign off before committing.



================
Comment at: include/clang/Basic/AttrDocs.td:612
+  let Content = [{
+The ``convergent`` attribute can be placed on function declarations. It is
+translated to LLVM ``convergent`` attribute, which indicates the call
----------------
aaron.ballman wrote:
> on a function declaration
"declarations" should be singular (declaration).


================
Comment at: test/SemaOpenCL/convergent.cl:1
+// RUN: %clang_cc1 -triple spir-unknown-unknown -verify %s
+
----------------
Should add `-fsyntax-only` to the test.


https://reviews.llvm.org/D25343





More information about the cfe-commits mailing list