[PATCH] D25540: Implement MS _ReturnAddress and _AddressOfReturnAddress intrinsics

Hans Wennborg via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 13 00:38:56 PDT 2016


hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

lgtm with a comment



================
Comment at: test/CodeGen/ms-intrinsics.c:3
 // RUN:         -triple i686--windows -Oz -emit-llvm %s -o - \
-// RUN:         | FileCheck %s -check-prefix=CHECK -check-prefix=CHECK-I386
+// RUN:         | FileCheck %s -check-prefixes CHECK,CHECK-I386,CHECK-X86
 // RUN: %clang_cc1 -ffreestanding -fms-extensions -fms-compatibility -fms-compatibility-version=17.00 \
----------------
Using CHECK-X86 for both 32- and 64-bit might be confusing to the reader. Maybe call it CHECK-INTEL? (Or maybe it's juts me that's confused.)


https://reviews.llvm.org/D25540





More information about the cfe-commits mailing list