[PATCH] D25531: [libcxx] [test] Include <algorithm> in string_view::copy test

Billy Robert O'Neal III via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 12 12:48:19 PDT 2016


BillyONeal created this revision.
BillyONeal added reviewers: EricWF, mclow.lists.
BillyONeal added a subscriber: cfe-commits.

The string_view::copy test calls std::min, which is not required to be
made available by including <string_view>.

(The MSVC++ STL does not use std::min internally because we need to
avoid the *macro* named min which is defined by windows.h)


https://reviews.llvm.org/D25531

Files:
  test/std/strings/string.view/string.view.ops/copy.pass.cpp


Index: test/std/strings/string.view/string.view.ops/copy.pass.cpp
===================================================================
--- test/std/strings/string.view/string.view.ops/copy.pass.cpp
+++ test/std/strings/string.view/string.view.ops/copy.pass.cpp
@@ -19,6 +19,7 @@
 
 
 #include <string_view>
+#include <algorithm>
 #include <cassert>
 
 #include "test_macros.h"


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25531.74423.patch
Type: text/x-patch
Size: 376 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161012/08f0c30e/attachment.bin>


More information about the cfe-commits mailing list