[PATCH] D25520: [CodeCompletion] Add block placeholders when completing member access for Objective-C block property setters

Argyrios Kyrtzidis via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 12 11:27:29 PDT 2016


akyrtzi added a comment.

What if the user just wants to invoke the block, this is as common or more, like:

`self.onEventHandler(10)`

The assign literal completion is useful but it should be an additional entry (with maybe lower priority) not replace the property completion.
BTW, it would be great we had completion as if it was a function call, so 2 entries, 1 for block invocation and 1 for assigning literal. Absence the block invocation call it should be 1 for normal property completion and 1 for assigning literal.


Repository:
  rL LLVM

https://reviews.llvm.org/D25520





More information about the cfe-commits mailing list