[PATCH] D25145: [libc++] Correct explanation of _LIBCPP_NEW_DELETE_VIS

Shoaib Meenai via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 12 06:55:21 PDT 2016


smeenai added a comment.

In https://reviews.llvm.org/D25145#565027, @mclow.lists wrote:

> Sigh. Make an expedient choice that you don't really agree with, and you get immediately reminded of it.   I suggested on an earlier review (not this patch) that I really didn't want to see `_WIN32` in any files other than `<config>`, that we should have a libc++-specific one.  I let that slide because we had a couple other instances of `_WIN32` in the source base.
>
> About three days later, this pops up. :-(
>  Not your fault, but it makes me sad.


I'm not a fan either :) Gonna commit this and then send something to cfe-dev about cleaning them up.


https://reviews.llvm.org/D25145





More information about the cfe-commits mailing list