[PATCH] D25508: [clang-move] Don't comparing absolute file path to relative path.

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 12 03:03:24 PDT 2016


hokein created this revision.
hokein added a reviewer: ioeric.
hokein added subscribers: bkramer, cfe-commits.
Herald added subscribers: mgorny, beanz.

This patch is kind of reverting r283202 (but keep the updated lint test),
because it leads to a few annoying problems by comparing absolute file path to
the relative path:

- MakeAbsolutePath does wrong things with symlinks.
- Removing `..` directory is not always safe.


https://reviews.llvm.org/D25508

Files:
  clang-move/ClangMove.cpp
  clang-move/ClangMove.h
  clang-move/tool/ClangMoveMain.cpp
  test/CMakeLists.txt
  test/clang-move/Inputs/database_template.json
  test/clang-move/move-class.cpp
  unittests/clang-move/ClangMoveTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25508.74352.patch
Type: text/x-patch
Size: 17034 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161012/e733620a/attachment-0001.bin>


More information about the cfe-commits mailing list