[PATCH] D25008: [cmake] Split linked libraries into private & public, for linker script

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Sat Oct 8 02:51:14 PDT 2016


EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

One concern I have is being able to specify libraries in the correct order when we have two different lists. However I'm not concerned enough not to try it.

LGTM.



================
Comment at: lib/CMakeLists.txt:43
+  # Apple re-exports libc++abi in libc++, so don't make it public
+  add_library_flags("${LIBCXX_CXX_ABI_LIBRARY}")
+else()
----------------
Urg. I think this whole setup is borked on Apple. This was an existing issue though, so you don't have to fix it. this LGTM for now.


https://reviews.llvm.org/D25008





More information about the cfe-commits mailing list