[PATCH] D25369: [clang-move] Better support enclosing class.

[Haojian Wu via cfe-commits]

hokein added inline comments.


================
Comment at: clang-move/ClangMove.cpp:27
 
+AST_MATCHER_P(CXXMethodDecl, ofOutermostEnclosingClass,
+              ast_matchers::internal::Matcher<CXXRecordDecl>, InnerMatcher) {
----------------
ioeric wrote:
> I'm not sure if we really need to limit this to the `outer-most` class. In the future, we might want to support moving nested class, so I guess this can simply be `ofClass`? Not sure if the name is right though.
`clang-move` can't handle nested classes well enough currently, and supporting nested class requires more stuff there, like changing the qualifiers of the method definitions in the nested class  (`int A::B::f()` should be `int B::f()` when moving nested class `A::B`). So we'd better to only allow `outer-most` class at least for now .


https://reviews.llvm.org/D25369