[PATCH] D25343: [OpenCL] Mark group functions as noduplicate in opencl-c.h

[Yaxun Liu via cfe-commits]

yaxunl added a comment.

In https://reviews.llvm.org/D25343#564092, @arsenm wrote:

> These should be convergent instead


Unfortunately convergent is not supported as Clang attribute. There was patch to add it but the author withdrew it.

Anastasia/Alexey,

Do you think it is a good idea to add __attribute__((convergent)) to clang and mark these group functions with it?

convergent put more restrictions on what transformations are allowed, whereas noduplicate only forbids duplicate of the function calls.

Thanks.


https://reviews.llvm.org/D25343