[PATCH] D24085: arm: Fix ttype encoding assertion failure.

Marshall Clow via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 5 07:09:42 PDT 2016


mclow.lists added inline comments.


> cxa_personality.cpp:363
> +           "Unexpected TTypeEncoding");
>      (void)ttypeEncoding;
>  

It's not clear to me how this accomplishes what you want.
You're looking for `00/10/90`, right?  Why not just check for that?

Why are you anding with 0x0f ?
Before, this would pass only a single value - `DW_EH_PE_absptr` (aka 0)
With this change, it passes 32 values: 00, 03, 10, 13, 20, 23, and so on.

Was that your intent?

https://reviews.llvm.org/D24085





More information about the cfe-commits mailing list