[PATCH] D25153: preprocessor supports `-dI` flag

Steve O'Brien via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 4 18:08:07 PDT 2016


elsteveogrande added a comment.

Thanks -- will do one more pass



> majnemer wrote in PrintPreprocessedOutput.cpp:409-411
> Why not have sanitizePath return a `std::vector<char>`?

Hmm, good idea.  Better than caller-passed vectors, and it be whatever size is needed (in the called method I'd `CharVector.reserve` anyway).  The return of that vector should get elided.

https://reviews.llvm.org/D25153





More information about the cfe-commits mailing list