[PATCH] D25153: preprocessor supports `-dI` flag

[David Majnemer via cfe-commits]

majnemer added inline comments.


> majnemer wrote in PrintPreprocessedOutput.cpp:321-325
> Variables should start with uppercase characters.

Please uppercase all your other variables too.

> PrintPreprocessedOutput.cpp:344
> + */
> +bool tryGetTokenText(StringRef *text, const Token &tok) {
> +  if (tok.getKind() == clang::tok::identifier) {

Could this just return a StringRef? You could use an empty StringRef on failure.

https://reviews.llvm.org/D25153