r283193 - [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

Dean Michael Berris via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 4 01:22:47 PDT 2016


Author: dberris
Date: Tue Oct  4 03:22:47 2016
New Revision: 283193

URL: http://llvm.org/viewvc/llvm-project?rev=283193&view=rev
Log:
[XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

Added the code which explicitly emits an error in Clang in case
`-fxray-instrument` is passed, but XRay is not supported for the
selected target.

Author: rSerge

Reviewers: dberris, rsmith, aaron.ballman, rnk

Subscribers: cfe-commits, iid_iunknown

Differential Revision: https://reviews.llvm.org/D24799

Added:
    cfe/trunk/test/Driver/xray-instrument.c
Modified:
    cfe/trunk/lib/Driver/Tools.cpp

Modified: cfe/trunk/lib/Driver/Tools.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=283193&r1=283192&r2=283193&view=diff
==============================================================================
--- cfe/trunk/lib/Driver/Tools.cpp (original)
+++ cfe/trunk/lib/Driver/Tools.cpp Tue Oct  4 03:22:47 2016
@@ -4777,7 +4777,20 @@ void Clang::ConstructJob(Compilation &C,
 
   if (Args.hasFlag(options::OPT_fxray_instrument,
                    options::OPT_fnoxray_instrument, false)) {
-    CmdArgs.push_back("-fxray-instrument");
+    const char *const XRayInstrumentOption = "-fxray-instrument";
+    switch (getToolChain().getArch()) {
+    case llvm::Triple::arm:
+    case llvm::Triple::x86_64:
+      break;
+    default: {
+      std::string Feature(XRayInstrumentOption);
+      Feature += " on ";
+      Feature += Triple.getArchName().data();
+      D.Diag(diag::err_drv_clang_unsupported) << Feature;
+      break;
+    }
+    }
+    CmdArgs.push_back(XRayInstrumentOption);
     if (const Arg *A =
             Args.getLastArg(options::OPT_fxray_instruction_threshold_,
                             options::OPT_fxray_instruction_threshold_EQ)) {

Added: cfe/trunk/test/Driver/xray-instrument.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/xray-instrument.c?rev=283193&view=auto
==============================================================================
--- cfe/trunk/test/Driver/xray-instrument.c (added)
+++ cfe/trunk/test/Driver/xray-instrument.c Tue Oct  4 03:22:47 2016
@@ -0,0 +1,3 @@
+// RUN: %clang -v -fxray-instrument -c %s
+// XFAIL: armeb, aarch64, aarch64_be, avr, bpfel, bpfeb, hexagon, mips, mipsel, mips64, mips64el, msp430, ppc, ppc64, ppc64le, r600, amdgcn, sparc, sparcv9, sparcel, systemz, tce, thumb, thumbeb, x86-, xcore, nvptx, nvptx64, le32, le64, amdil, amdil64, hsail, hsail64, spir, spir64, kalimba, shave, lanai, wasm32, wasm64, renderscript32, renderscript64
+typedef int a;




More information about the cfe-commits mailing list