[PATCH] D24815: [clang] make reciprocal estimate codegen a function attribute

Mehdi AMINI via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 3 17:54:29 PDT 2016


mehdi_amini added inline comments.


> spatel wrote in CGCall.cpp:1735
> Good point - I think we have to convert all codegen tests that have these function-level attributes to IR FMF and make sure that the output doesn't change. Definitely not part of this patch, but hopefully something that can be done incrementally, test-by-test.

I wonder if we couldn’t have this part of the bitcode/IR auto-upgrade: when we load a function with this attribute, we automatically add the individual flag on every instruction.

https://reviews.llvm.org/D24815





More information about the cfe-commits mailing list