[PATCH] D24598: Separate builtins for x84-64 and i386; implement __mulh and __umulh

Reid Kleckner via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 3 16:20:43 PDT 2016


rnk added inline comments.


> agutowski wrote in BuiltinsX86_32.def:1
> Will we ever need that file? It seems to nicely complement the 64-bit one, but if it's going to be empty forever maybe it's better to remove it.

I guess we should remove it. Take a look at isX86_64Builtin in Sema/SemaChecking.cpp. It might be good to, as a follow-up change, move those builtins over to BuiltinsX86_64.def.

https://reviews.llvm.org/D24598





More information about the cfe-commits mailing list