[PATCH] D25131: Fix PR 28885: Fix AST Printer output for inheriting constructor using declarations

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 30 15:38:27 PDT 2016

rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.

Minor comment, otherwise LGTM.

> DeclPrinter.cpp:1350-1351
> +
> +  // PR 28885: Use the correct record name when the using declaration is used
> +  // for inheriting constructors.
> +  for (const auto *Shadow : D->shadows()) {

Don't list PR numbers here. Your code and its comments should be sufficient to explain what you're doing and why without this.



More information about the cfe-commits mailing list