[PATCH] D25129: [CUDA] Disallow __constant__ local variables.

Artem Belevich via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 30 15:04:46 PDT 2016

tra added inline comments.

> jlebar wrote in DiagnosticSemaKinds.td:6727
> That's still a "global variable"?  Or do you think calling it such will be confusing?

It's not clear whether you mean global storage class or global namespace.
The code checks for global storage, but error message is could be interpreted either way, IMO.

I'll leave phrasing up to you.


More information about the cfe-commits mailing list