[PATCH] D24986: [MS] Implement __iso_volatile loads/stores as builtins

Martin Storsjö via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 30 11:09:51 PDT 2016

mstorsjo added inline comments.

> majnemer wrote in ms-volatile-arm.c:2
> You don't need -fms-volatile.

Well, originally, the point was to clarify that these volatile stores end up without atomic semantics, regardless of whether -volatile:ms has been specified. The original version of this patch (with an inline implementation in intrin.h, just using a normal volatile pointer) wouldn't pass this test, but would pass if I remove this option. But if you prefer, I can leave it out.


More information about the cfe-commits mailing list