[PATCH] [Updated, 225 lines] D24864: [libcxxabi] Refactor pthread usage into a separate API
Asiri Rathnayake via cfe-commits
cfe-commits at lists.llvm.org
Fri Sep 30 01:59:43 PDT 2016
rmaprath updated this revision to Diff 73007.
rmaprath added a comment.
Updated with the following changes:
- Address review comments from @EricWF and @compnerd regarding using `_POSIX_THREADS` for detecting pthread availability. Now the patch is checking for `defined(_POSIX_THREADS) && _POSIX_THREADS >= 0` instead of enumerating the platforms.
- Fix a missed pthread dependency in `cxa_guard.cpp`. The call to `pthread_mach_thread_np` is now replaced with `__libcxxabi_thread_get_current_id()`.
- Fix a couple of missing pthread dependencies in `test_exception_storage.cpp` (see patch below).
@EricWF: Hope the new changes look OK? I'm going to test this on a Mac before committing.
I will also ping https://reviews.llvm.org/D21803 and https://reviews.llvm.org/D17815, as they'll be affected by this patch (those patches add more pthread calls).
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 15661 bytes
Desc: not available
More information about the cfe-commits