[PATCH] [Commented On] D24380: [migrate-tool] Framework for a codebase-dependent migration tool.

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 30 01:57:36 PDT 2016

klimek added inline comments.

> MigrateTool.cpp:52
> +  // Get all files that are affected by the migration, i.e. users of the symbol.
> +  auto Files = Env.getAffectedFilesFinder().getAffectedFiles(Spec.getOldName());
> +  if (!Files)

I'm wondering whether we really want to evolve this to a callback / executor based design. That is, have AffectedFilesFinder give an interface like RunOnAffectedFiles(...)


More information about the cfe-commits mailing list