[PATCH] D24864: [libcxxabi] Refactor pthread usage into a separate API

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 28 14:44:51 PDT 2016

EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

LGTM once the `_POSIX_THREADS` comment is addressed.

Comment at: src/config.h:46
@@ +45,3 @@
+    defined(__linux__) || \
+    defined(__APPLE__) || \
+    defined(__CloudABI__) || \
I think what @compnerd means is that `_POSIX_THREADS` can be used to detect if the current platform supports/provides `pthreads.h`. So instead of enumerating the OS's that support them manually we can just replace that check with `defined(_POSIX_THREADS)` after including `unistd.h`.


More information about the cfe-commits mailing list