[PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

[Hal Finkel via cfe-commits]

hfinkel added inline comments.

================
Comment at: lib/Driver/Tools.cpp:243
@@ +242,3 @@
+    // ignore inputs that refer to OpenMP offloading devices - they will be
+    // embedded recurring to a proper linker script.
+    if (auto *IA = II.getAction())
----------------
recurring -> according

================
Comment at: lib/Driver/Tools.cpp:334
@@ +333,3 @@
+  LksStream << "  OpenMP Offload Linker Script.\n";
+  LksStream << "*/\n";
+  LksStream << "TARGET(binary)\n";
----------------
We should also say 'autogenerated' somewhere in this comment.

================
Comment at: lib/Driver/Tools.cpp:386
@@ +385,3 @@
+  // Dump the contents of the linker script if the user requested that.
+  if (C.getArgs().hasArg(options::OPT_fopenmp_dump_offload_linker_script))
+    llvm::errs() << LksBuffer;
----------------
I don't see why this is needed if we have -save-temps - I think we should remove this option entirely.


https://reviews.llvm.org/D21847