[PATCH] D24397: Target Power9 bit counting and vector comparison instructions through builtins (front end portion)

Nemanja Ivanovic via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 28 09:40:29 PDT 2016

nemanjai added a comment.

In https://reviews.llvm.org/D24397#555470, @spatel wrote:

> Having a clang regression/unit test that depends on optimizer behavior is generally viewed as wrong. Can the tests be split into front-end (clang) tests and separate tests for the IR optimizer? Both x86 and AArch64 have done something like that in the last few months for testing of builtins/intrinsics.

Yeah, that sounds reasonable. I'll remove the -O2 from the test case and remove the checks for the select instructions. That's really the only major difference. So am I to understand the nsw/nuw flags will not be added without -O2 and the aforementioned changes will suffice?



More information about the cfe-commits mailing list