[PATCH] D23662: [libclang] Control whether crash recovery is enabled/disabled using function argument.

Argyrios Kyrtzidis via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 28 09:25:45 PDT 2016


akyrtzi added a comment.

> I could disable crash recovery by calling clang_toggleCrashRecovery(false) after clang_createIndex has been called but this doesn't work because the right JVM handler isn't reinstalled


Could you explain more why this doesn't work ? Is it a bug with the crash handling logic or something else ?

If we are going to have a 'clang_createIndex2' function to be able to introduce a new flag, it should be made to accept OR'ed enums for flags, so we can add more flags in the future and not get in a similar situation and have to add 'clang_createIndex3'..


Repository:
  rL LLVM

https://reviews.llvm.org/D23662





More information about the cfe-commits mailing list