[PATCH] D25008: [libcxx] Include unwinder library in the linker script

Michał Górny via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 28 02:22:10 PDT 2016

mgorny added a comment.

In https://reviews.llvm.org/D25008#555041, @rmaprath wrote:

> The patch generally makes sense to me.
> I wonder if the test configuration can also benefit from this; `test/libcxx/test/target_info.py` manually updates the link line to use `-lgcc_s` or `-lunwind` depending on how the build is configured. Presumably, this workaround will no longer be needed if the linker script does that for us?

I was originally thinking about that but we don't use the linker script on APPLE and I have no clue how that system is handled or whether it suffers from the same issue at all.

> (Note:- `-lgcc_s` is linked twice there to satisfy some weird dependency, it's not a mistake)

Thanks for letting me know. I almost prepared a patch for that ;-D.


More information about the cfe-commits mailing list