[PATCH] D24979: [CUDA] Support <complex> and std::min/max on the device.

Justin Lebar via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 27 13:28:04 PDT 2016

jlebar added a comment.

> I' personally would prefer to force-include these files. I suspect it will not change things much as we already include a lot.

We have already had bugs filed by users whose root cause was that we #included more things than nvcc #includes.  I know exact compatibility with nvcc is not our goal, but unless we have a good reason I don't think we should break compatibility with nvcc *and* the C++ standard by force-including additional system headers.

> This looks like fix-includes and it may be somewhat shaky if users start messing with include paths.

We add this include path first, so I think it should be OK?  What do you think, @echristo.


More information about the cfe-commits mailing list