[PATCH] D24914: [clang-rename] Do not print out error message upon encountering multiple replacements in the same SourceLocation.

Kirill Bobyrev via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 27 12:38:14 PDT 2016

omtcyfz added inline comments.

Comment at: clang-rename/RenamingAction.cpp:74
@@ +73,3 @@
+      // FIXME: An error might happen here if USRLocFinder finds the symbol
+      // twice or if the symbol happens to be in a header included multiple
+      // times independently. Such error doesn't mean clang-rename failure and
alexshap wrote:
> My concerns were about wording, the new version looks good to me.
> I think the long-term fix would be to improve the interface of the class Replacements,
> but it's clearly not in the scope of this patch (the other tools have the same issue), 
> so to me your diff is OK.
Eric actually has a patch for that: https://reviews.llvm.org/D24800


More information about the cfe-commits mailing list