[PATCH] D24800: Merge conflicting replacements when they are order-independent.

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 27 08:52:23 PDT 2016

klimek added inline comments.

Comment at: lib/Tooling/Core/Replacement.cpp:179-181
@@ +178,5 @@
+Replacements::mergeIfOrderIndependent(const Replacement &R) const {
+  Replacements Rs(R);
+  Replacements RsShiftedByReplaces(getReplacementInChangedCode(R));
+  Replacements ReplacesShiftedByRs;
I think this is a bit subtle and needs a lot more comments to guide me along what is happening and why ...


More information about the cfe-commits mailing list