[PATCH] D19586: Misleading Indentation check

Gábor Horváth via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 27 03:52:37 PDT 2016


xazax.hun added inline comments.

================
Comment at: test/clang-tidy/readability-misleading-indentation.cpp:16
@@ +15,3 @@
+              // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: wrong indentation, 'else' belongs to 'if(cond2)' statement
+              // CHECK-FIXES: {{^}}  // comment1
+
----------------
Pajesz wrote:
> alexfh wrote:
> > Did you run the tests after changes? I don't think the `// comment1` line can actually appear in the fixed code, when it's not there before the fix.
> Could you please explain what check-fixes does and how? Im not sure about it.
You can read the documentation here: http://clang.llvm.org/extra/clang-tidy/#testing-checks

Didn't you execute the tests? (Using make check-all or some similar command)

The CHECK-FIXES line will check the content of the file after the fixits are applied. The check will fail when the specified pattern is not found in the result.


https://reviews.llvm.org/D19586





More information about the cfe-commits mailing list