[PATCH] D24922: [clang-move] Make it support both relative and absolute file path arguments.

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 27 02:55:46 PDT 2016

hokein added inline comments.

Comment at: clang-move/ClangMove.cpp:62
@@ +61,3 @@
+  return MakeAbsolutePath(SourceManager, FileEntry->getName()) ==
+         AbsoluteFilePath;
ioeric wrote:
> To generalize the function, maybe also remove dots in `AbsoluteFilePath`?
`AbsoluteFilePath` has been removed dots, and the matcher here is only used internally by clang-move, so I'd prefer the current way here, if we meet the generalized case in the future, I will be happy to extend it.


More information about the cfe-commits mailing list