[PATCH] D24809: [libcxx] [cmake] Stop stripping -m32 from compiler flags

Michał Górny via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 26 22:46:06 PDT 2016

mgorny added a comment.

In https://reviews.llvm.org/D24809#553415, @EricWF wrote:

> > Stop stripping -m32 from the user-supplied flags. There is no valid reason to do that, stripping it silently is thoroughly confusing and makes it impossible to do distribution multi-ABI builds without resorting to ugly hacks.
> The reason for stripping it is configurations like `-DLLVM_BUILD_32_BITS=ON -DLIBCXX_BUILD_32_BITS=OFF`, where we inherit the incorrect set of flags from the LLVM parent project. I understand your frustration with this behavior but I'm not sure how else to handle that.

Well, I'm afraid this only proves that the whole concept is broken and shouldn't be there in the first place ;-).

However, if this is the only case, maybe the stripping should be made conditional to in-tree builds?


More information about the cfe-commits mailing list