[PATCH] D24914: [clang-rename] Do not print out error message upon encountering multiple replacements in the same SourceLocation.

[Alexander Kornienko via cfe-commits]

alexfh requested changes to this revision.
This revision now requires changes to proceed.

================
Comment at: clang-rename/RenamingAction.cpp:73
@@ -73,1 +72,3 @@
       llvm::Error Err = FileToReplaces[Replace.getFilePath()].add(Replace);
+      // FIXME: As for clang-rename, replacement fails IFF either the AST node
+      // has been matched multiple times (which shouldn't happen in reality,
----------------
Did you mean "adding a replacement fails..."?

================
Comment at: clang-rename/RenamingAction.cpp:75
@@ +74,3 @@
+      // has been matched multiple times (which shouldn't happen in reality,
+      // need to fix that) or when it's a specific header. For now, just ignore 
+      // the error that happened as it doesn't mean a failure.
----------------
"Specific header"? What exactly does it mean here?


https://reviews.llvm.org/D24914