[PATCH] D24820: Add -stats-stats option

Matthias Braun via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 26 13:54:54 PDT 2016

MatzeB added inline comments.

Comment at: test/Driver/save-stats.c:12
@@ +11,3 @@
+// RUN: %clang -target x86_64-apple-darwin -save-stats=obj -c -o obj/dir/save-stats.o %s -### 2>&1 | FileCheck %s -check-prefix=CHECK-OBJ
+// CHECK-OBJ: "-stats-file=obj/dir{{/|\\\\}}save-stats.stats"
+// CHECK-OBJ: "-o" "obj/dir{{/|\\\\}}save-stats.o"
bruno wrote:
> aprantl wrote:
> > This is up to taste, but just accepting {{.}} as the path separator would be sufficient IMO and might be more readable.
> +1 to Adrian's suggestion
For the record: Switching to {{.}} in the final commit broke the windows bots, because they display an escaped slash here (= two backslash characters)...



More information about the cfe-commits mailing list