[PATCH] D24886: Add [[clang::suppress(rule, ...)]] attribute

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 26 13:14:10 PDT 2016

aaron.ballman added a comment.

In https://reviews.llvm.org/D24886#552859, @rsmith wrote:

> Giving this the name `[[clang::suppress(...)]]` seems unhelpful. This attribute is specified by the C++ core guidelines, not by clang, and presumably we want code using this attribute to be portable across implementations of the C++ code guidelines. I'd suggest asking the editors of the core guidelines what attribute namespace they'd like used, and using that here rather than using `clang`.

I believe this attribute should be used to silence diagnostics for more than just the C++ Core Guidelines, so I don't think it makes sense to let them dictate what attribute namespace should be used. However, I would appreciate if they didn't suggest implementers stomp all over the attribute namespace used by standards-based attributes, either.


More information about the cfe-commits mailing list