[PATCH] D24862: Workaround ASTMatcher crashes. Added some more test cases.

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 26 07:21:04 PDT 2016


aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM, thank you!


================
Comment at: change-namespace/ChangeNamespace.cpp:279-281
@@ -276,3 +278,5 @@
   Finder->addMatcher(
-      usingDecl(hasAnyUsingShadowDecl(IsInMovedNs)).bind("using_decl"), this);
+      usingDecl(IsInMovedNs, hasAnyUsingShadowDecl(decl())).bind("using_decl"),
+      this);
+
   // Handle types in nested name specifier.
----------------
I had originally thought that this was changing behavior, but I am starting to think this is actually fine.


https://reviews.llvm.org/D24862





More information about the cfe-commits mailing list