[clang-tools-extra] r282388 - [clang-rename] Use checktime when reloading vim buffer after applying clang-rename

Kirill Bobyrev via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 26 00:26:32 PDT 2016

Author: omtcyfz
Date: Mon Sep 26 02:26:32 2016
New Revision: 282388

URL: http://llvm.org/viewvc/llvm-project?rev=282388&view=rev
[clang-rename] Use checktime when reloading vim buffer after applying clang-rename

After applying `clang-rename` to a vim buffer (using `clang-rename.py` as part
of the vim integration) the buffer gets reloaded using `bufdo`. This solution is
suboptimal, since syntax highlighting is turned off for performance reasons and
never turned on, after all changes to the source file have been applied.

A better solution to this is using `checktime`. It is exactly designed for this
kind of task and doesn't have the syntax highlighting issue.

Patch by Kai Wolf!

Reviewers: omtcyfz

Differential Revision: https://reviews.llvm.org/D24791


Modified: clang-tools-extra/trunk/clang-rename/tool/clang-rename.py
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-rename/tool/clang-rename.py?rev=282388&r1=282387&r2=282388&view=diff
--- clang-tools-extra/trunk/clang-rename/tool/clang-rename.py (original)
+++ clang-tools-extra/trunk/clang-rename/tool/clang-rename.py Mon Sep 26 02:26:32 2016
@@ -54,7 +54,7 @@ def main():
         print stderr
     # Reload all buffers in Vim.
-    vim.command("bufdo edit")
+    vim.command("checktime")
 if __name__ == '__main__':

More information about the cfe-commits mailing list