r282255 - Fix for r280064 that added options for fp denormals and exceptions.

Sjoerd Meijer via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 23 09:12:20 PDT 2016

Nothing was breaking, but it wasn't working either (because those options were not copied).
I've reverted the patch directly after the first buildbot failure.

I don't think I am committing at will:  I thought it was okay to commit directly because it is a simple fix (or should be) for my own  previous half-working patch, but I don't mind going through phab.

I am indeed suspecting it is missing default case (probably got confused because e.g. ThreadModel also doesn't have one, at least not there).


-----Original Message-----
From: Renato Golin [mailto:renato.golin at linaro.org]
Sent: 23 September 2016 17:00
To: Sjoerd Meijer
Cc: Clang Commits
Subject: Re: r282255 - Fix for r280064 that added options for fp denormals and exceptions.

On 23 September 2016 at 16:21, Sjoerd Meijer via cfe-commits <cfe-commits at lists.llvm.org> wrote:
> Author: sjoerdmeijer
> Date: Fri Sep 23 10:21:33 2016
> New Revision: 282255
> URL: http://llvm.org/viewvc/llvm-project?rev=282255&view=rev
> Log:
> Fix for r280064 that added options for fp denormals and exceptions.
> These options were forgotten to be copied in setCommandLineOpts.

This broke:


> +  Options.FPDenormalType =
> +    llvm::StringSwitch<llvm::FPDenormal::DenormalType>(CodeGenOpts.FPDenormalMode)
> +      .Case("ieee", llvm::FPDenormal::IEEE)
> +      .Case("preserve-sign", llvm::FPDenormal::PreserveSign)
> +      .Case("positive-zero", llvm::FPDenormal::PositiveZero);

No Default case?

> +  Options.NoTrappingFPMath = CodeGenOpts.NoTrappingMath;

This is not the same as the one above. Are you sure this patch is correct?

Has this been reviewed at all?

Please, don't commit patches at will when nothing is breaking, and put the patch for review next time.


IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

More information about the cfe-commits mailing list