[PATCH] D24862: Workaround ASTMatcher crashes. Added some more test cases.

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 23 07:07:47 PDT 2016

aaron.ballman added a comment.

In https://reviews.llvm.org/D24862#550628, @ioeric wrote:

> In https://reviews.llvm.org/D24862#550615, @aaron.ballman wrote:
> > Should this perhaps be fixed in the AST matchers rather than in the check itself?
> I'll file bugs for the crashes, but the fix in this patch is not that "dirty" - it simply changes the order of matchers to workaround the crashes. So I guess this doesn't need to wait for the fix in matcher library.

Whenever possible, we should be fixing the underlying bugs, not working around them.


More information about the cfe-commits mailing list