r282148 - Fixing sphinx build due to diagnostic:

[Aaron Ballman via cfe-commits]

On Thu, Sep 22, 2016 at 9:41 AM, Teresa Johnson <tejohnson at google.com> wrote:
>
>
>
> On Thu, Sep 22, 2016 at 6:38 AM, Aaron Ballman <aaron at aaronballman.com> wrote:
>>
>> On Thu, Sep 22, 2016 at 9:34 AM, Teresa Johnson <tejohnson at google.com> wrote:
>> > Hi Aaron,
>> >
>> > I just went back to the bot, which had first failed with a process error
>> > when I made my commit which is why I didn't see this error. It looks like it
>> > is still failing with the same error:
>> >
>> > http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/16313/steps/docs-clang-html/logs/stdio
>> > (that build has your fix).
>> >
>> > Unfortunately, I can't reproduce this locally, which is why I didn't see it
>> > in my testing. I confirmed my build is using the same command line, so I can
>> > only surmise that I must be using a different version of sphinx.
>>
>> I run into the same problem -- I cannot reproduce it locally either.
>> I've just hit this problem several times before and was speculatively
>> fixing it. I have no idea how this bot is configured and why
>> configuration is different. :-(
>>
>> > AFAICT your change should have fixed this error. Any idea why it is still
>> > giving it?
>>
>> The option directives are really persnickety about how things are
>> spelled. It's possible that it just doesn't like the "=blah" part at
>> all. We could remove the :option: usage from the paragraph and leave
>> the .. option:: directive in the title. That's another way I've solved
>> this in the past.
>
>
> Ok, I'll go ahead and do that. It's odd that it doesn't seem to be complaining about the -flto=thin reference a few lines below.

Thank you for taking care of it! Also, welcome to the world of Sphinx,
where that's not odd, it's The Way Things Work. :-D Once Sphinx hits
an error, it seems to stop reporting more errors.

> Do you know if the pages at http://clang.llvm.org/docs/ will automatically be refreshed once this is fixed?

I believe they should, yes.

~Aaron

>
> Teresa
>
>>
>> ~Aaron
>>
>> >
>> > Thanks,
>> > Teresa
>> >
>> >
>> > On Thu, Sep 22, 2016 at 6:10 AM, Teresa Johnson <tejohnson at google.com>
>> > wrote:
>> >>
>> >> Thank you!
>> >> Teresa
>> >>
>> >> On Thu, Sep 22, 2016 at 5:15 AM, Aaron Ballman via cfe-commits
>> >> <cfe-commits at lists.llvm.org> wrote:
>> >>>
>> >>> Author: aaronballman
>> >>> Date: Thu Sep 22 07:15:18 2016
>> >>> New Revision: 282148
>> >>>
>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=282148&view=rev
>> >>> Log:
>> >>> Fixing sphinx build due to diagnostic:
>> >>>
>> >>>
>> >>> /opt/llvm/build.attributes.src/tools/clang/docs/CommandGuide/clang.rst:338:
>> >>> WARNING: unknown option: -flto=full
>> >>>
>> >>> Modified:
>> >>>     cfe/trunk/docs/CommandGuide/clang.rst
>> >>>
>> >>> Modified: cfe/trunk/docs/CommandGuide/clang.rst
>> >>> URL:
>> >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/CommandGuide/clang.rst?rev=282148&r1=282147&r2=282148&view=diff
>> >>>
>> >>> ==============================================================================
>> >>> --- cfe/trunk/docs/CommandGuide/clang.rst (original)
>> >>> +++ cfe/trunk/docs/CommandGuide/clang.rst Thu Sep 22 07:15:18 2016
>> >>> @@ -328,7 +328,7 @@ Code Generation Options
>> >>>    model can be overridden with the tls_model attribute. The compiler
>> >>> will try
>> >>>    to choose a more efficient model if possible.
>> >>>
>> >>> -.. option:: -flto[=full,thin], -emit-llvm
>> >>> +.. option:: -flto, -flto=full, -flto=thin, -emit-llvm
>> >>>
>> >>>    Generate output files in LLVM formats, suitable for link time
>> >>> optimization.
>> >>>    When used with :option:`-S` this generates LLVM intermediate language
>> >>>
>> >>>
>> >>> _______________________________________________
>> >>> cfe-commits mailing list
>> >>> cfe-commits at lists.llvm.org
>> >>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>> >>
>> >>
>> >>
>> >>
>> >> --
>> >> Teresa Johnson | Software Engineer | tejohnson at google.com | 408-460-2413
>> >
>> >
>> >
>> >
>> > --
>> > Teresa Johnson | Software Engineer | tejohnson at google.com | 408-460-2413
>
>
>
>
> --
> Teresa Johnson | Software Engineer | tejohnson at google.com | 408-460-2413