[PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 22 05:44:32 PDT 2016

aaron.ballman added a comment.

In https://reviews.llvm.org/D22910#549611, @sylvestre.ledru wrote:

> What about landing this version now (with test) and do the other operators in the a second commit? thanks

I don't see a whole lot of value in that, but I may be missing information -- is this patch gating some other work? Supporting increment and decrement should be pretty straight-forward and is logically related to the current changeset. I'd prefer to fix it all at once since it shouldn't be overly onerous (and it protects us from accidentally only implementing part of the functionality), but if there's a reason to split it out, then I don't see harm in that either.


More information about the cfe-commits mailing list