[PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

Vitaly Buka via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 21 11:57:59 PDT 2016


Intrinsics are invalid there, code is generated in such way that variable
is being accessed after lifetime.end.
I suspect that optimizer can make invalid code because of this, but I can't
reproduce.
So I think it's safer to remove them at all and don't wait for miscompile
reports.

Still if performance is greater concern then potential miscompiles, I can
limit this only to asan-use-after-scope.



On Wed, Sep 21, 2016 at 8:49 AM Akira Hatanaka <ahatanak at gmail.com> wrote:

> ahatanak added a comment.
>
> Do we want to remove lifetime intrinsics when we aren't doing the
> asan-use-after-scope check? Since this isn't a mis-compile caused by
> inaccurate lifetime intrinsics, I was wondering whether we should do this
> only when asan-use-after-scope is on to minimize the impact on compile time.
>
>
> https://reviews.llvm.org/D24693
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160921/657de583/attachment.html>


More information about the cfe-commits mailing list