[PATCH] D24809: [libcxx] [cmake] Stop stripping -m32 from compiler flags
Michał Górny via cfe-commits
cfe-commits at lists.llvm.org
Wed Sep 21 09:51:56 PDT 2016
mgorny created this revision.
mgorny added a reviewer: EricWF.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
Stop stripping -m32 from the user-supplied flags. There is no valid reason to do that, stripping it silently is thoroughly confusing and makes it impossible to do distribution multi-ABI builds without resorting to ugly hacks.
Otherwise, in order to perform 32-bit builds the build scripts would have to use LIBCXX_BUILD_32_BITS. However, -m32 is only one of the many different ABI flags for different targets, and it really makes no sense to add separate CMake options for each possible -m* flag and then keep a mapping from well-known flags to the custom CMake options.
@@ -309,7 +309,7 @@
# Remove flags that may have snuck in.
remove_flags(-DNDEBUG -UNDEBUG -D_DEBUG
- -stdlib=libc++ -stdlib=libstdc++ -lc++abi -m32)
+ -stdlib=libc++ -stdlib=libstdc++ -lc++abi)
# FIXME(EricWF): See the FIXME on LIBCXX_ENABLE_PEDANTIC.
# Remove the -pedantic flag and -Wno-pedantic and -pedantic-errors
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 479 bytes
Desc: not available
More information about the cfe-commits