[PATCH] D24791: Use checktime when reloading vim buffer after applying clang-rename

Kai Wolf via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 21 00:26:43 PDT 2016

NewProggie created this revision.
NewProggie added a subscriber: cfe-commits.

After applying `clang-rename` to a vim buffer (using `clang-rename.py` as part of the vim integration) the buffer gets reloaded using `bufdo`. This solution is suboptimal, since syntax highlighting is turned off for performance reasons and never turned on, after all changes to the source file have been applied. 

A better solution to this is using `checktime`. It is exactly designed for this kind of task and doesn't have the syntax highlighting issue.



Index: clang-rename/tool/clang-rename.py
--- clang-rename/tool/clang-rename.py
+++ clang-rename/tool/clang-rename.py
@@ -54,7 +54,7 @@
         print stderr
     # Reload all buffers in Vim.
-    vim.command("bufdo edit")
+    vim.command("checktime")
 if __name__ == '__main__':

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24791.72011.patch
Type: text/x-patch
Size: 354 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160921/ff706813/attachment.bin>

More information about the cfe-commits mailing list